Version 0.6.0 #64
Merged
Version 0.6.0 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a Keychain wrapper for better credential storage; refactoring
Fixing memory leaks leading to unreleased modal view controllers
Allow dex credentials to be updated within the app settings
Allow NIghtscout credentials to be updated within the app settings
Allow mLab and Amplitude credentials to be updated within the app settings
…peripherals hits 0 Fixes #36
Clear "Loop Not Running" notifications when the number of configured …
Read glucose + pump data deterministically for x22 + G4 Share users
Fixing the transition state to Carb and Bolus entry view controllers
Backfill up to 30 minutes of glucose from Share
erikdi
pushed a commit
to erikdi/Loop
that referenced
this pull request
Feb 10, 2019
ps2
pushed a commit
that referenced
this pull request
May 12, 2020
* checkpoint * checkpoint - kind of working * checkpoint * checkpoint * tweak * unused import * Fix a bug introduced when I cleaned up the code * PR Feedback * PR Feedback * Wrap up the `managerIdentifier` and `typeIdentifier` into a single type, `Identifier` * PR Feedback: renaming: UserAlert* -> DeviceAlert* scheduleAlert -> issueAlert unscheduleAlert -> removePendingAlerts cancelAlert -> removeDeliveredAlerts * More renaming, move acknowledgeDeviceAlert to DeviceAlertManager (where it really should've been) * Project file, removeAlertResponder * More PR Feedback: get rid of AcknowledgeCompletion * added a comment * PR feedback: renaming only deviceManagerInstanceIdentifier -> deviceManagerIdentifier removePendingAlerts -> removePendingAlert removeDeliveredAlerts -> removeDeliveredAlert * More PR Feedback: - Made `alertsShowing` and `alertsPending` a dictionary, by request. Also took the opportunity to add some bulletproofing "preconditions". - Also, a bonus: I didn't like the asymmetry of the `DeviceAlertManagerResponder` protocol, and it was unnecessary. So a small change there. * PR feedback: one more rename: deviceManagerIdentifier -> managerIdentifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteSettings.plistis now deprecated. Service credentials are now available in the settings screen. Credentials will be migrated on first launch, thenRemoteSettings.plistcan be cleared out. The project reference will be removed in an upcoming version. (Move RemoteSettings.plist config into the app #35)